PHP Deprecated messages for DLR in general
Posted December 1st, 2011 by chadmills
Project: | RUcore dlr/EDIT |
Version: | 6.1 |
Component: | Code |
Category: | bug report |
Priority: | critical |
Assigned: | triggs |
Status: | closed |
Jump to:
Description
Many PHP scripts exhibit the behavior of having deprecated functions used. Please identify and update those scripts. Let me know which were modified and how they can be tested.
Comments
#1
I think these are all done for dlr, dlr/EDIT, and disseminators. At least I hope so;-)
#2
This bug is still an issue
<a href="http://software.libraries.rutgers.edu/node/1539" title="http://software.libraries.rutgers.edu/node/1539">http://software.libraries.rutgers.edu/node/1539</a>
#3
Another one found
/dlr/EDIT/XMLFORM/editusers.php
#4
I am marking this fixed but not closed. I think all of the deprecated messages have either been fixed in out tickets and/or identified and being fixed. I am not closing this until all other tickets are closed and a grep across all of the files shows that ereg(), ereg_replace() and split() are not found.
#5
I ran grep across dlr/EDIT only and I found the following regarding the three known deprecated functions, split(), ereg() and ereg_replace(). These functions are still present in code. It is hard to determine without a through audit if they are commented out or if the scripts that use the functions are no longer used. A cleanup needs to occur.
cmmills@rep-devel:/mellon/htdocs/dlr/EDIT> grep -rl "ereg(" .
./old2-getfedorasql.php
./WORK/sqlcomm-nonlocalhost.php
./WORK/doamberindex5.php
./WORK/ashowfed.php
./WORK/doamberindex6.php
./WORK/new-061109-XPath.class.php
./WORK/unused-XPath.class.php
./WORK/older-phpxpath-XPath.class.php
./WORK/older-redosigslite.php
./WORK/foo-runsignatures.php
./WORK/older-XPath.class.php
./XMLFORM/testedit6.php
./XMLFORM/test2edit6.php
./notification-20090122/XPath.class.php
./old-addds.php
./xpath/class/XPath.class.php
./runfindsigs.php
./old-getfedorasql.php
cmmills@rep-devel:/mellon/htdocs/dlr/EDIT> grep -rl "ereg_replace(" .
./old2-getfedorasql.php
./WORK/sqlcomm-nonlocalhost.php
./WORK/ashowfed.php
./WORK/doamberindex6.php
./WORK/foogetfedoraapia.php
./WORK/older-redosigslite.php
./WORK/foo2getfedoraapia.php
./WORK/foo-runsignatures.php
./XMLFORM/testedit6.php
./XMLFORM/test2edit6.php
./notification-20090122/alert_data.php
./notification-20090122/alert_data.bk.php
./xpath/validate.php
./includes/viewsmap.php
./old-getfedorasql.php
cmmills@rep-devel:/mellon/htdocs/dlr/EDIT> grep -rl " split(" .
./old2-getfedorasql.php
./WORK/doxacml2.php
./WORK/ashowfed.php
./WORK/fooapi.php
./WORK/doxacml.php
./WORK/foogetfedoraapia.php
./WORK/foo.php
./WORK/older-redosigslite.php
./WORK/foo2getfedoraapia.php
./WORK/foo-runsignatures.php
./WORK/getpolicyframes.php
./getmarcframes.php
./foopurgerels.php
./collection_delete_collid.php
./searchstring_collectionsR4_2.php
./redosigslite.php
./exportobj.php
./runsolrpost.php
./searchstring_collections_cmm.php
./searchstring_collections.php
./old-getfedorasql.php
./gsitemap.php
./notification5.2/cl_update_fedoralive_typenull.php
#6
#7
#8
Chad,
When you get a chance, can you test this bug please?
KA
#9
Still found in ereg() in:
xpath/class/XPath.class.php
#10
Changed the two instances in XPath.class.php.
#11
There are a number of what looks like are WORK and other non used files that are still being reported. I am going to mark this as fixed with the hope those files are moved out of the dlr directory to dlr-dev one day.
#12
The files in WORK are in a directory marked in .cvsignore and are not part of the distribution.
#13